Remove the checkout UI #4947
Merged
Remove the checkout UI #4947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bye Felicia |
aldeed
force-pushed
the
feat-aldeed-remove-checkout-ui
branch
from
4cc0448
to
15592d5
Compare
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
aldeed
force-pushed
the
feat-aldeed-remove-checkout-ui
branch
from
15592d5
to
141b15b
Compare
Merged
mikemurray
requested changes
Jan 30, 2019
There was a problem hiding this comment.
I get the following error for react-stripe-elements needed for component library components.
reaction_1 | Unable to resolve some modules:
reaction_1 |
reaction_1 | "react-stripe-elements" in
reaction_1 | /opt/reaction/src/node_modules/@reactioncommerce/components/utils/withStripeElements.js
reaction_1 | (web.browser.legacy)Needed by the component library until we get tree shaking working Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
|
@mikemurray I added that package back until we get component library tree shaking working properly. I had that error, too, and I thought I had fixed, but must not have committed it. Sorry for the trouble. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: major
Type: feature
Changes
BREAKING CHANGE
All links, buttons, routes, and components related to checkout are now removed. This helps clarify the fact that in 2.0, this app is only to be used as an API and a UI for shop operators. Storefront UI can be built from scratch or by starting from https://github.com/reactioncommerce/reaction-next-starterkit.
Additional PRs will be coming to remove other pieces of the storefront UI bit by bit until only an operator UI is left.
Testing
/operatorpage still works.